Skip to content

Conversation

imShakil
Copy link
Contributor

Description

It will update the fluentd-elasticsearch image version from an outdated tag to a more recent version in the DaemonSet example.

Changes

  • Updated image: quay.io/fluentd_elasticsearch/fluentd:v5.0.1 to use current version

Issue

Closes: #51585

Copy link

linux-foundation-easycla bot commented Jul 16, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: imShakil / name: Mobarak Hosen Shakil (ae0125d)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 16, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @imShakil!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 16, 2025
@k8s-ci-robot k8s-ci-robot requested a review from tengqm July 16, 2025 11:51
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 16, 2025
Copy link

netlify bot commented Jul 16, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ae0125d
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68787a7317a7820008f21105
😎 Deploy Preview https://deploy-preview-51626--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@intojhanurag
Copy link
Contributor

Thanks for the PR @imShakil!
Looks good to me
Now just waiting for approval from reviewers.
Let us know if you need help!

/cc @divya-mohan0209 @tengqm

@shurup
Copy link
Member

shurup commented Jul 17, 2025

Hi @imShakil, thank you for fixing this! Would you mind bringing the same change to the fluentd-daemonset.yaml file as well, please? Currently, it uses the same outdated image (fluentd:v2.5.2), and it makes sense to fix it in all 3 files at once 🙏

@imShakil
Copy link
Contributor Author

badly missed! I have updated now. Thanks

@shurup
Copy link
Member

shurup commented Jul 17, 2025

Perfect, thank you!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3a11d03a385c92a3869e452487d53d203aa8b14b

@xirehat
Copy link
Member

xirehat commented Jul 17, 2025

Considering that the Fluentd site itself refers to the Kubernetes site, why don't we use the official Docker image mentioned there?
@imShakil @intojhanurag @shurup

@reylejano
Copy link
Member

Considering that the Fluentd site itself refers to the Kubernetes site, why don't we use the official Docker image mentioned there? @imShakil @intojhanurag @shurup

Looks like the Fluentd site doesn't reference a specific tag
image: quay.io/fluent/fluentd-kubernetes-daemonset

We should use a specific tag

@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9adc367 into kubernetes:main Jul 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DaemonSet example is not working in Macbook

6 participants